enhance: reduce checkpoint GC and index metrics overhead - #27
Merged
sunby merged 1 commit intoSep 9, 2026
Conversation
Signed-off-by: sunby <sunbingyi1992@gmail.com>
sunby
merged commit Sep 9, 2026
c85b05b
into
codex/load-1m-segments-pr-stack-rebased-qv-work
10 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduce two sources of periodic coordinator allocation without changing their scheduling intervals:
DescribeCollectionor retaining an entry in the sweep's fallback-result map. Unknown, unavailable, unhealthy, or unsupported cases retain the existingHasCollectionandGcConfirmchecks; a negative cache result never authorizes deletion.This is a follow-up to #23, targeting
codex/load-1m-segments-pr-stack-rebased-qv-workatbc6a0ddbd2adba5da4274bfc2b526abaa70bd8f2.Related scalability context: milvus-io#48867. That issue concerns million-segment collection recovery; this PR does not claim to resolve its QueryNode recovery problem.
Correctness boundaries
GcConfirmhandling.Verification
Validated on submission commit
d23fdf6147c7a30d2ff2a04b478404df6335b510, after a conflict-free rebase;git range-diffconfirmed the patch was unchanged.All Go tests and benchmarks use
-tags dynamic,test -gcflags='all=-N -l':pkg/util/funcutil.pkg/util/funcutillint: 0 issues.git diff --checkpassed.make lint-fix: blocked by pre-existinginternal/metastore/kv/querycoord/kv_catalog_test.go:372:15: undefined: mocks. That file is identical in the target base and submission. Ranrun_clang_format.shwith clang-format 15. Neither formatter changed any PR file; unrelated formatting output was excluded.Local performance evidence and limitations
Synthetic benchmarks on Apple M5 / Go 1.26.5, three repetitions with compiler optimizations disabled:
Incremental bookkeeping adds O(indexes) resident counter storage and constant work to metadata transitions; it does not make all metadata operations allocation-free. Tests used existing local native artifacts and mocked metadata writes. Full
make test-go, a newly built production image, end-to-end deployment tests, and live MixCoord CPU/GC comparison have not been run. No claim is made that this eliminates the deployed CPU sawtooth or achieves a specific live CPU reduction.